Skip to content

Remove "Filter by letter" feature #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Remove "Filter by letter" feature #4360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions app/controllers/crates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
import Controller from '@ember/controller';
import { action } from '@ember/object';
import { tracked } from '@glimmer/tracking';

import { reads } from 'macro-decorators';

import { pagination } from '../utils/pagination';

export default class CratesController extends Controller {
queryParams = ['letter', 'page', 'per_page', 'sort'];
@tracked letter = null;
queryParams = ['page', 'per_page', 'sort'];
@tracked page = '1';
@tracked per_page = 50;
@tracked sort = 'alpha';
alphabet = [...'ABCDEFGHIJKLMNOPQRSTUVWXYZ'];

@reads('model.meta.total') totalItems;
@pagination() pagination;
Expand All @@ -30,8 +27,4 @@ export default class CratesController extends Controller {
return 'Alphabetical';
}
}

@action handleSelection(event) {
this.set('letter', event.target.value);
}
}
7 changes: 0 additions & 7 deletions app/routes/crates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,11 @@ export default class CratesRoute extends Route {
@service store;

queryParams = {
letter: { refreshModel: true },
page: { refreshModel: true },
sort: { refreshModel: true },
};

model(params) {
// The backend throws an error if the letter param is
// empty or null.
if (!params.letter) {
delete params.letter;
}

return this.store.query('crate', params);
}
}
19 changes: 0 additions & 19 deletions app/templates/crates.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,6 @@

<PageHeader @title="All Crates" @suffix={{if this.letter (concat "starting with '" this.letter "'")}}/>

<div local-class='selection'>
{{#each this.alphabet as |letter|}}
<LinkTo @query={{hash letter=letter page=1}}>
{{ letter }}
</LinkTo>
{{/each}}

<label local-class="filter-dropdown-label">
Filter by letter:

<select local-class="filter-dropdown" {{on "change" this.handleSelection}}>
<option value="">No Filter</option>
{{#each this.alphabet as |letter|}}
<option value={{letter}} selected={{eq letter this.letter}}>{{ letter }}</option>
{{/each}}
</select>
</label>
</div>

<div local-class="results-meta">
<ResultsCount
@start={{this.pagination.currentPageStart}}
Expand Down