Repository: Extract write_temporary_ssh_key() function
#4363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-backend ⚙️
C-internal 🔧
Turbo87
force-pushed
the
key-function
branch
from
8cab772 to
9161e60
Compare
Turbo87
changed the title
write_temporary_ssh_key() functionwrite_temporary_ssh_key() function
Turbo87
force-pushed
the
key-function
branch
from
9161e60 to
abdaa20
Compare
bors
added a commit
that referenced
this pull request
Dec 26, 2021
Repository: Extract `run_command()` function This new function makes it easier to run arbitrary `git` commands in the working folder of the local index clone. It was extracted from the `squash_index()` background worker tasks, which uses it to run `git push --force-with-lease`, which is not yet supported by the `git2` crate. The main goal of this PR is to reduce the visibility of the `checkout_path` and `credentials` fields on the `Repository`, which outside code should ideally not have any access to. Note that this includes the commits from and is based on #4363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts, simplifies and documents the code that temporarily writes the in-memory SSH key to the disk for consumption in
git pushwhen the index is squashed.