Skip to content

Toggle stacked download graph #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 3, 2022
Merged

Toggle stacked download graph #5010

merged 4 commits into from
Aug 3, 2022

Conversation

billy1624
Copy link
Contributor

Related Issues:

This PR add a button to the graph of download counts which toggle between stacked / unstacked graph.

Screenshots:

  • Stacked graph: image
  • Unstacked graph: image

@billy1624
Copy link
Contributor Author

I guess a dropdown would be more appropriate? Similar to below

image

@billy1624
Copy link
Contributor Author

I updated it to a dropdown

  • image
  • image

Turbo87
Turbo87 reviewed Jul 28, 2022
View reviewed changes
Turbo87
Turbo87 reviewed Jul 28, 2022
View reviewed changes
@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jul 28, 2022
@billy1624 billy1624 requested a review from Turbo87 July 28, 2022 10:03
Turbo87
Turbo87 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! :)

@Turbo87 Turbo87 merged commit 3e5f0b4 into rust-lang:master Aug 3, 2022
@billy1624
Copy link
Contributor Author

Thanks! @Turbo87

@Turbo87 Turbo87 mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billy1624 @Turbo87