Allow '+' in keywords #5046
Merged
Allow '+' in keywords #5046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: keywords = ["c++"].
Turbo87
reviewed
Aug 3, 2022
There was a problem hiding this comment.
seems reasonable on first glance, though I'd like to get a second opinion on this first.
@jtgeibel @carols10cents any thoughts?
Turbo87
added
C-enhancement ✨
JohnTitor
reviewed
Aug 11, 2022
Turbo87
approved these changes
Aug 20, 2022
|
@dtolnay sorry that it took so long. it should be live in production now :) |
|
Thank you! Seems to work: https://crates.io/keywords/c++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior art: '+' in feature names — #2510. See that PR for the rationales in favor of that.
Specifically I would be interested in using "c++" as a tag on some of my FFI crates. Alphanumericizing it to "cpp" or "cxx" is not so good because those are each the name of a specific crate for a specific approach to C++ interop, and a crate that's generally suitable for C++ interop wouldn't want its keywords to imply it only works in concert with one of those two other crates.
Cargo has supported '+' in keywords since Rust 1.1.