Skip to content

Versions: Add color explanations on hover #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2023

Conversation

ToBinio
Copy link
Contributor

@ToBinio ToBinio commented May 5, 2023

This PR should resolve #6238

though implementing this suggested solution.
Screenshot 2023-05-05 153337

it also adds similar color coding to the version (Release Track) text.
Screenshot 2023-05-05 154213

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels May 8, 2023
@ToBinio
Copy link
Contributor Author

ToBinio commented May 10, 2023

I am not completely happy with the way you select which color bracket-mark has. But I couldn't think of any better way without something like typescript support.

@Turbo87 Turbo87 force-pushed the color_for_recent_publish_date branch from 8fe61bc to 2d3a64c Compare May 11, 2023 08:39
@Turbo87
Copy link
Member

Turbo87 commented May 11, 2023

@ToBinio I've rebased and simplified the implementation a little bit. Since we are using CSS modules we can import the CSS module in the JS code to gain access to the class name mapping and use that (plus htmlSafe()) to add <span> tags to the tooltips.

@Turbo87 Turbo87 force-pushed the color_for_recent_publish_date branch from 2d3a64c to 3bd54e8 Compare May 11, 2023 08:43
@Turbo87 Turbo87 merged commit cd35a64 into rust-lang:master May 11, 2023
@ToBinio ToBinio deleted the color_for_recent_publish_date branch May 14, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yellow text for recent publish date may be confusing
2 participants