Skip to content

publish: Remove dsl::* import #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 3, 2023

These imports always cause a lot of name clashes with local variables since they often match the SQL column names. By prefixing the column names with the table name we can easily avoid this confusing issue.

This creates too many variables in the function with ambiguous names...
This is no longer needed since the name clash with the SQL column has been resolved
This is no longer needed since the name clash with the SQL column has been resolved
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 3, 2023
@Turbo87 Turbo87 enabled auto-merge October 3, 2023 11:21
@Turbo87 Turbo87 merged commit ba02d0e into rust-lang:main Oct 3, 2023
@Turbo87 Turbo87 deleted the dsl-star-imports branch October 3, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant