Enable setting database pool limits from environment variables #732
+40
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
force-pushed
the
db-env-vars
branch
from
45f32ea to
b396f96
Compare
carols10cents
force-pushed
the
db-env-vars
branch
from
b396f96 to
1169382
Compare
sgrif
reviewed
May 23, 2017
| @@ -47,15 +48,33 @@ impl App { | |||
|
|
|||
| github.scopes.push(String::from("read:org")); | |||
|
|
|||
| let db_pool_size = match (env::var("DB_POOL_SIZE"), config.env) { | |||
There was a problem hiding this comment.
Do you think it's worth just removing the env defaults and assume that if the var is unset it's in development mode?
There was a problem hiding this comment.
I'd like reasonable production defaults as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sgrif I'm trying to test out #730 on staging and I'm overwhelming the db limit of 20 connections there again :( This'll let me set prod and staging differently. I did unify the settings for rust-postgres and diesel though, with the thought that hopefully we'll be getting rid of the rust-postgres connections soon anyway.