Fix IP-based request blocking #7435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LawnGnome
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
It occurs to me that we should probably document BLOCKED_IPS somewhere at some point along with its exact semantics (comma separated, whitespace not ignored, unless we add a str::trim to the chain where we collect the HashSet from the environment variable), but I don't think that's important in this PR.
We should probably also add some tests for the blocking eventually, since this is all in-process now and we should be able to do so. Again, not urgent right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #7434 explains, IP-based request blocking is currently broken. This PR fixes the blocking based on the
BLOCKED_IPSenvironment variable that we use on production.