controllers/crates: default to sort by recent downloads #7889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Jan 7, 2024
Turbo87
added
C-enhancement ✨
|
@punkeel it looks like a couple of tests are failing though. could you take a look? |
|
Digging into the failure a bit further, to make the test pass, you need to:
|
"Browse All Crates" is the most prominent link in the menu bar, displayed on all pages. Before this change, this link would present the user with (mostly) irrelevant crates, as it was sorted alphabetically: crates like `a`, `a-`, `a0`, etc. With this change, the list is now sorted to present the most downloaded crates first. `/keywords/:term` already defaults to that same order.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7889 +/- ##
==========================================
+ Coverage 89.04% 89.06% +0.02%
==========================================
Files 278 278
Lines 27987 27987
==========================================
+ Hits 24922 24928 +6
+ Misses 3065 3059 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Browse All Crates" is the most prominent link in the menu bar, displayed on all pages. Before this change, this link would present the user with (mostly) irrelevant crates, as it was sorted alphabetically: crates like
a,a-,a0, etc.With this change, the list is now sorted to present the most downloaded crates first.
/keywords/:termalready defaults to that same order.