Use ember-metrics to handle Google Analytics #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Jun 30, 2017
app/mixins/google-pageview.js
Outdated
| Ember.run.scheduleOnce('afterRender', this, () => { | ||
| const page = this.get('url'); | ||
| const title = this.getWithDefault('currentRouteName', 'unknown'); | ||
| Ember.get(this, 'metrics').trackPage({ page, title }); |
There was a problem hiding this comment.
Is the afterRender scheduling necessary here?
There was a problem hiding this comment.
Is it an overkill? Thought I'd keep it there for prioritising the route load over ga stuff
There was a problem hiding this comment.
just noticed that it's mentioned in the ember-metrics README like this, so it's probably fine. still wondering if it's really still needed though.
Turbo87
reviewed
Jun 30, 2017
app/mixins/google-pageview.js
Outdated
| title: this.get('url') | ||
| Ember.run.scheduleOnce('afterRender', this, () => { | ||
| const page = this.get('url'); | ||
| const title = this.getWithDefault('currentRouteName', 'unknown'); |
There was a problem hiding this comment.
title had been set to this.get('url') too until now. maybe we should keep it like that for now and change that in a separate PR?
There was a problem hiding this comment.
Yeah thought I'd get opinions on the PR on this. Will switch to current values
Turbo87
approved these changes
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of async loading of ga.js & disables on ember 'dev' & 'test' environments.