Skip to content

workers/jobs/dump_db: Apply date prefix when creating tarball #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 28, 2024

Instead of exporting into a prefixed folder we can apply the datetime prefix when creating the tarball. This allows us to skip the prefix for other output formats in the future and it also simplifies the DumpDirectory struct.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels May 28, 2024
Instead of exporting into a prefixed folder we can apply the datetime prefix when creating the tarball. This allows us to skip the prefix for other output formats in the future and it also simplifies the `DumpDirectory` struct.
@Turbo87 Turbo87 enabled auto-merge (squash) May 28, 2024 14:07
@Turbo87 Turbo87 merged commit f6e877d into rust-lang:main May 28, 2024
7 checks passed
@Turbo87 Turbo87 deleted the tarball-prefix branch May 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant