Skip to content

Update expiry notification to use the copy token link #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Jul 10, 2024

ref #8717

Tested locally:

  1. Start the crates.io in the docker
crates.io on ξ‚  rustin-patch-copy-token via 🐳 orbstack is πŸ“¦ v0.0.0 via  v20.13.0 via πŸ¦€ v1.81.0-nightly took 2s 
❯ docker ps
CONTAINER ID   IMAGE               COMMAND                  CREATED          STATUS             PORTS                                       NAMES
7ce772c8b3b2   cratesio-worker     "cargo run --bin bac…"   4 minutes ago    Up 4 minutes                                                   cratesio-worker-1
5047a4401dfe   cratesio-frontend   "pnpm start"             10 minutes ago   Up 10 minutes      0.0.0.0:4200->4200/tcp, :::4200->4200/tcp   cratesio-frontend-1
e740cac267e7   cratesio-backend    "/app/docker_entrypo…"   10 minutes ago   Up 10 minutes      0.0.0.0:8888->8888/tcp, :::8888->8888/tcp   cratesio-backend-1
f7d983f426bb   postgres:16         "docker-entrypoint.s…"   12 days ago      Up About an hour   127.0.0.1:5432->5432/tcp                    cratesio-postgres-1
  1. Create a new token which will expire within one day
image
  1. Trigger a background job: DATABASE_URL=postgresql://postgres:password@localhost:5432/cargo_registry ./target/debug/crates-admin enqueue-job check_about_to_expire_token

  2. Check the email from the worker's tmp dir

image

@0xPoe 0xPoe requested a review from a team July 10, 2024 14:22
@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend βš™οΈ labels Jul 10, 2024
@Turbo87 Turbo87 force-pushed the rustin-patch-copy-token branch from fdb5ca5 to 5251876 Compare July 11, 2024 09:27
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

@Turbo87 Turbo87 enabled auto-merge (squash) July 11, 2024 09:28
@Turbo87 Turbo87 merged commit 128f451 into rust-lang:main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend βš™οΈ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants