Skip to content

Add support for regenerating the token #9122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Jul 19, 2024

Resolves #8717

The reason I chose "regenerate" instead of "copy" is that the latter is quite confusing. Users might think it means copying the token value.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jul 19, 2024
@0xPoe
Copy link
Member Author

0xPoe commented Jul 19, 2024

Test locally:

Screen.Recording.2024-07-19.at.10.10.15.PM.mov

@0xPoe 0xPoe force-pushed the rustin-patch-regenerate branch from 2d7236f to 446acf2 Compare July 19, 2024 14:12
@0xPoe 0xPoe requested a review from a team July 19, 2024 14:13
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (fcc05d7) to head (f30d80b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9122      +/-   ##
==========================================
- Coverage   89.21%   89.19%   -0.03%     
==========================================
  Files         282      282              
  Lines       28511    28511              
==========================================
- Hits        25435    25429       -6     
- Misses       3076     3082       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 force-pushed the rustin-patch-regenerate branch from 446acf2 to f30d80b Compare July 22, 2024 08:01
@Turbo87 Turbo87 force-pushed the rustin-patch-regenerate branch from f30d80b to 3135cc7 Compare July 22, 2024 09:39
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Turbo87 Turbo87 enabled auto-merge July 22, 2024 09:39
@Turbo87 Turbo87 merged commit 77c46a2 into rust-lang:main Jul 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API tokens: Add "Copy" functionality
2 participants