Change version downloads archive location to static S3 bucket #9180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9180 +/- ##
==========================================
+ Coverage 89.15% 89.19% +0.04%
==========================================
Files 282 282
Lines 28529 28514 -15
==========================================
Hits 25434 25434
+ Misses 3095 3080 -15 ☔ View full report in Codecov by Sentry. |
|
☔ The latest upstream changes (presumably #9161) made this pull request unmergeable. Please resolve the merge conflicts. |
4 tasks
LawnGnome
approved these changes
Jul 30, 2024
Previously we were uploading the version downloads exports to a dedicated bucket, but the infra team decided that it would be best to use the `static` bucket instead. This changes the upload location by switching from a dedicated `ObjectStore` instance to a `PrefixStore` based on our `Storage` struct and the `archive/version-downloads` prefix.
Turbo87
force-pushed
the
version-downloads-move
branch
from
77a9d2f to
910d64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were uploading the version downloads exports to a dedicated bucket, but the infra team decided that it would be best to use the
staticbucket instead. This changes the upload location by switching from a dedicatedObjectStoreinstance to aPrefixStorebased on ourStoragestruct and thearchive/version-downloadsprefix.