-
Notifications
You must be signed in to change notification settings - Fork 210
Improve topbar crate dropdown menu by removing uneeded information #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve topbar crate dropdown menu by removing uneeded information #1259
Conversation
@GuillaumeGomez instead of adding a new link text that's always the same, what do you think about making 'Regex 1.3.1' a link? |
Because it's not "obvious" when reading it. The problem I had with most of the original items is that I needed to look at the |
@GuillaumeGomez this already has a link to /crate under 'more information' on the sidebar: So I don't think it makes sense to add another link, and I kind of like having the description. I would be ok with making the title a link instead of the description, but otherwise I don't see much point to this. |
I didn't even realize there was a "more information" link. What about I remove it? :) |
We definitely do need to do something about the embedded description, it gets really over the top sometimes e.g. https://docs.rs/chess/3.1.1/chess/. Removing it does seem like the easiest approach, the majority of the time it seems like this will just be a duplicate of the first few sentences of the crate-level docs. As another point towards minimizing our exposure of the description, on crates.io you get to see the description for about a second before it is replaced by the readme; afaict there is no way to then go back to viewing the description. I feel like the "More Information" link is a bit hidden, I have personally been using the description as the link, but I think it makes more sense than adding another link under the crate name. Maybe we could have both the "More Information" link and make the name a link? |
I think the menu should be minimalist and that the docs.rs crate page link should be easier to find. So I'm fine with removing the "More information" link. Now, the big remaining quest is either we turn the crate name into this link (but then, it's not explicit where it's leading to so I'm not a big fan) or keeping the "docs.rs crate page" I suggested. |
I think we should get rid of 'More information' and make the crate name a link. I think that's clear enough, you only have to click it once to find what it does. |
I agree for removing "more information", but why someone would expect that clicking on the crate name would bring to another page? It's not obvious at all. |
I removed the "More information" link which was now a duplicate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm still not convinced the separate link is better than making the crate name a link, but it's certainly better than the current behavior.
I always found the link to go to the crate page very misleading because you don't expect a description to be this link. Instead, I removed this description from the menu completely (I think the menu is already very loaded) and made it clear what the link was about.