Standardize environment variables on DOCSRS_ #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
C-technical-debt
jyn514
force-pushed
the
cratesfyi
branch
3 times, most recently
from
f5b46f2 to
3508810
Compare
|
@pietroalbini do you have time to review this? |
jyn514
added
the
S-waiting-on-review
|
I'm wondering if we should have some code that errors out if the old environment variables are present, pointing to the new ones. That would help with people's local development environments, especially ones that are used occasionally. |
|
@pietroalbini we can't do that until this is deployed because the production server needs to be able to switch between the two, there's no way to switch the environment and update the code at the same time currently. Happy to turn it into a hard error in a future PR. |
|
Sure, sounds good to have it in a followup PR! |
Previously, it could be used inconsistently with the CRATESFYI_PREFIX environment variable, which was confusing.
This changes the following env variables used in prod: - CRATESFYI_PREFIX - CRATESFYI_DATABASE_URL - CRATESFYI_GITHUB_ACCESSTOKEN - CRATESFYI_RUSTWIDE_WORKSPACE - CRATESFYI_TOOLCHAIN - DOCS_RS_BUILD_CPU_LIMIT Before deploying, we should set the new names of all these variables. After deploying, we can delete the old names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the following env variables used in prod:
Before deploying, we should set the new names of all these variables.
After deploying, we can delete the old names.
Helps with #244.