Skip to content

use new github issue forms for build-failure and sandbox-limits templates #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2021

Conversation

syphar
Copy link
Member

@syphar syphar commented May 14, 2021

(draft PR so I can see the preview and validation for the template)

@syphar syphar force-pushed the issue-forms branch 5 times, most recently from ea4f2ef to 6e77161 Compare May 14, 2021 05:45
@syphar syphar self-assigned this May 14, 2021
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying this! Left a few comments.

@syphar syphar marked this pull request as ready for review May 14, 2021 09:58
@syphar syphar requested a review from pietroalbini May 14, 2021 09:58
@syphar
Copy link
Member Author

syphar commented May 14, 2021

@pietroalbini I updated the files according to your comments, it's ready for another check

required: true
- type: input
attributes:
label: build failure link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other labels that don't start with a capitalized letter. Once all labels are capitalized we can merge this!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't know you meant all of them 😄

I'll update it later

@syphar syphar requested a review from pietroalbini May 14, 2021 10:35
@syphar
Copy link
Member Author

syphar commented May 14, 2021

@pietroalbini I updated the labels

@pietroalbini
Copy link
Member

Let's try the templates!

@pietroalbini pietroalbini merged commit 9cfc2c6 into rust-lang:master May 14, 2021
@syphar syphar deleted the issue-forms branch May 16, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants