fix clippy warning on non-linux systems #1455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
added
the
S-waiting-on-review
syphar
commented
Jul 31, 2021
src/docbuilder/rustwide_builder.rs
Outdated
| @@ -12,6 +12,7 @@ use crate::utils::{copy_dir_all, parse_rustc_version, CargoMetadata}; | |||
| use crate::{db::blacklist::is_blacklisted, utils::MetadataPackage}; | |||
| use crate::{Config, Context, Index, Metrics, Storage}; | |||
| use docsrs_metadata::{Metadata, DEFAULT_TARGETS, HOST_TARGET}; | |||
| #[cfg(target_os = "linux")] | |||
| use failure::ResultExt; | |||
There was a problem hiding this comment.
this is only used below in a section that is only compiled on linux, so this use is unused on all other platforms
There was a problem hiding this comment.
Could you move it into the function that uses it instead? That way the cfgs are automatically in sync instead of needing to update them in two places.
There was a problem hiding this comment.
I moved it into the block that uses it, not sure if that is the most idiomatic way :)
( I can move it to the function if that's what is better)
jyn514
approved these changes
Jul 31, 2021
syphar
force-pushed
the
new-clippy-warnings
branch
from
507c69c to
b00749f
Compare
syphar
force-pushed
the
new-clippy-warnings
branch
from
b00749f to
f84fa01
Compare
syphar
changed the title
|
@jyn514 since @GuillaumeGomez fixed the clippy warnings in his own PR (#1457), I update this one to be only the non-linux warning. |
GuillaumeGomez
approved these changes
Aug 9, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.