Skip to content

Upstream changes to badge crate #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2018

Conversation

srijs
Copy link
Contributor

@srijs srijs commented Feb 14, 2018

Hi!

I've recently started to use the badge crate on deps.rs.

This PR is to upstream some of the improvements I made, including:

  • updating rusttype from 0.2 to 0.4
  • removing the unused lifetype parameter from Badge (breaking change)
  • adding a Badge::to_svg_data_uri method

I can also break this down into multiple PRs if you'd like.

@onur
Copy link
Member

onur commented Mar 1, 2018

Hi @srijs, sorry it took a while but thanks for the PR!

@onur onur merged commit 97b8b0a into rust-lang:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants