Skip to content

Use try_init everywhere #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2018
Merged

Use try_init everywhere #258

merged 1 commit into from
Oct 31, 2018

Conversation

alanhdu
Copy link
Contributor

@alanhdu alanhdu commented Oct 31, 2018

I think I missed these when upgrading env_logger because the tests were skipped.

QuietMisdreavus
QuietMisdreavus approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@QuietMisdreavus QuietMisdreavus merged commit b4c8f59 into rust-lang:master Oct 31, 2018
@alanhdu alanhdu deleted the try_init branch October 31, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanhdu @QuietMisdreavus