Remove sources path and fix Vagrant vm #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vagrantfile
Outdated
| @@ -47,7 +47,7 @@ Vagrant.configure("2") do |config| | |||
| ############################################################ | |||
| lxc-attach -n cratesfyi-container -- apt-get update | |||
| lxc-attach -n cratesfyi-container -- apt-get install -y --no-install-recommends curl ca-certificates binutils gcc libc6-dev libmagic1 | |||
| lxc-attach -n cratesfyi-container -- su - cratesfyi -c 'curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain nightly-2018-10-20' | |||
| lxc-attach -n cratesfyi-container -- su - cratesfyi -c 'curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain nightly-2018-12-19' | |||
There was a problem hiding this comment.
I wonder if we can just set this to nightly instead of pinning a date to it. We're updating rustdoc on the production server often enough that updating this file every time may start to become too cumbersome.
There was a problem hiding this comment.
Yes that makes sense, ok changed to use nightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs.rs is been using
~/.cargo/registy/srcinstead ofsources_pathfor a while. This patch removessources_path, updates nightly compiler used in Vagrant, removes some unused dependency from Cargo.lock and removes unused dependency from sitemap.rs.Closes: #278