Skip to content

Improve readability of build logs #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

onur
Copy link
Member

@onur onur commented Feb 14, 2019

@onur onur requested a review from QuietMisdreavus February 14, 2019 09:54
Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Does this fix #296, then? cc @iliekturtles

@iliekturtles
Copy link
Contributor

#296 resolved by this PR. I'll close. Thanks!

@QuietMisdreavus
Copy link
Member

Oh wait, i just realized that it may not fix that issue, since this is meant to fix build logs, not source views. Still, i'll merge this; we can check out whether it fixes that issue once it's deployed.

@QuietMisdreavus QuietMisdreavus merged commit 94aa716 into rust-lang:master Feb 15, 2019
@iliekturtles
Copy link
Contributor

Good point. I forgot to check the full context of the scss change and it only applies to the .recent-releases-container. The fix for #296 would need the change applied to pre elements in .package-page-container (~line 546). The change could be applied there, but a fuller review of all the pre styles is probably a better idea.

@onur onur deleted the improve-build-log branch February 18, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants