clean up debug logging around "not found" errors #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently emit two
debug!()statements on 404 errors: a static "Requested resource not found" and a newer one that prints the path that 404'd. (The former also prints a different one for searches with no results, but "Requested resource not found" is enormously more common in the log.) This PR will strip out the less useful log line in favor of the one that displays what was actually not found.(It also includes a separate code formatting commit that reduces one level of indentation around that block, as a personal style preference - even though i was the one who wrote that block in the first place
>_>)