update cargo #355
Merged
update cargo #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as suggested on discord, a sustainable method of selecting a version of `cargo` to use is whatever commit is being used by rust-lang/rust. the version selected in this commit uses the current version as of 2019-05-13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain crates were not building on docs.rs because the Cargo it was using could not load in the
futures-previewfamily of crates. After bringing it up on Discord, the Cargo team suggested that blindly loadingcargofrom master (if we must use it as a library at all) is problematic, and that we should use the commit that is currently loaded on rust-lang/rust master, to ensure that it's at least somewhat in sync with master. We should investigate fully removing our dependency oncargoas a library in favor ofcargo metadataand calls to Cargo as a binary, to ensure that we don't run into situations like this again.