Skip to content

Refactored metadata.rs #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2020
Merged

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Apr 2, 2020

  • Removed redundant if lets
  • Minimized code duplication
  • Split off get fetching of the package table into a separate function
  • Overall style and formatting changes

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be useful if you removed the formatting changes.

@Kixiron
Copy link
Member Author

Kixiron commented Apr 3, 2020

Ah, turns out using &[Value] doesn't work because it's a closure fed into the function, and therefore its signature has to perfectly match

@Kixiron Kixiron requested a review from jyn514 April 3, 2020 15:10
@jyn514 jyn514 merged commit c29aa2b into rust-lang:master Apr 15, 2020
@Kixiron Kixiron deleted the data-meet-formatting branch April 15, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants