Add TreeUpdateBuilder to support git_tree_create_updated #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtriplett
force-pushed
the
git_tree_create_updated
branch
from
52e8c0c to
bccf7ea
Compare
joshtriplett
changed the title
ehuss
reviewed
Dec 22, 2020
git_tree_create_updated requires a length and a contiguous array of git_tree_update structures, each of which has a pointer to a C string. Create a builder, `TreeUpdateBuilder`, to wrap that safely without excessive copies.
joshtriplett
force-pushed
the
git_tree_create_updated
branch
from
bccf7ea to
d23a94f
Compare
|
@ehuss Fixed. |
ehuss
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git_tree_create_updated requires a length and a contiguous array of
git_tree_update structures, each of which has a pointer to a C string.
Create a builder,
TreeUpdateBuilder, to wrap that safely withoutexcessive copies.