Make Time::sign return a sane value #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation returns quasi-garbage, because it's reading from the wrong field. The patch includes tests to exercise the broken scenario.
staktrace
added a commit
to staktrace/mozsearch
that referenced
this pull request
Dec 27, 2020
staktrace
added a commit
to staktrace/mozsearch
that referenced
this pull request
Dec 29, 2020
staktrace
added a commit
to staktrace/mozsearch
that referenced
this pull request
Dec 30, 2020
staktrace
added a commit
to mozsearch/mozsearch
that referenced
this pull request
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation returns quasi-garbage, because
it's reading from the wrong field. The patch includes
tests to exercise the broken scenario.