add signal and raise bindings for windows #1176
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
xmclark
changed the title
separate for gnu and msvc scope resolve c_int these types are not allowed, and more scope resolution use size_t
xmclark
force-pushed
the
add-signal-and-raise-windows
branch
from
1ddf826 to
313483b
Compare
|
Hello @alexcrichton! I'm having a little trouble getting I can't explain why the gnu compiler is failing. The pointer arithmetic seems valid. I think I could also use a sanity check. Make sure everything looks right. I have never contributed to an FFI library before. |
|
Oh I think this is largely just a bug in our testing, you'll need to edit |
|
@bors: r+ |
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove WIP from this PR's title when it is ready for review. |
xmclark
force-pushed
the
add-signal-and-raise-windows
branch
from
4f67390 to
4c32b9f
Compare
xmclark
changed the title
|
I believe this is ready for review. I've added the signedness exception for mingw. Both windows targets have different names for the |
xmclark
force-pushed
the
add-signal-and-raise-windows
branch
from
5cb9c53 to
af19934
Compare
|
@bors: r+ |
|
📌 Commit af19934 has been approved by |
…chton add signal and raise bindings for windows This PR adds `signal` and `raise` bindings for windows. I don't know these functions or linux very well, so I leaned on other overrides of signal in the linux bindings, and the [cppreference page](https://en.cppreference.com/w/cpp/header/csignal) for adding the bindings. I added some constants that were shown on the [microsoft signal page](https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/signal?view=vs-2017) and used the default values I found spelunking through my own copy of `signal.h` that came along with visual studio. The automated tests pass and my toy apps use the `signal` and `raise` as expected. Let me know if there is anything else I need to do, or any extra tests to write. EDIT: currently working on getting a nice isolated msys2 environment I can use to dev against. - [x] msys2 env setup and building
|
☀️ Test successful - status-appveyor, status-travis |
This PR adds
signalandraisebindings for windows.I don't know these functions or linux very well, so I leaned on other overrides of signal in the linux bindings, and the cppreference page for adding the bindings.
I added some constants that were shown on the microsoft signal page and used the default values I found spelunking through my own copy of
signal.hthat came along with visual studio.The automated tests pass and my toy apps use the
signalandraiseas expected. Let me know if there is anything else I need to do, or any extra tests to write.EDIT:
currently working on getting a nice isolated msys2 environment I can use to dev against.