Skip to content

Do not allow rustup to fail #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Do not allow rustup to fail #1250

merged 3 commits into from
Feb 12, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Feb 9, 2019

Currently if rustup fails to download something the build will continue until that something is needed. This makes the job fail early and clearly.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 9, 2019

@bors: r+

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Feb 9, 2019

📌 Commit a7674aa has been approved by gnzlbg

bors added a commit that referenced this pull request Feb 9, 2019
Do not allow rustup to fail

Currently if rustup fails to download something the build will continue until that something is needed. This makes the job fail early and clearly.
@bors
Copy link
Contributor

bors commented Feb 9, 2019

⌛ Testing commit a7674aa with merge d095337...

@bors
Copy link
Contributor

bors commented Feb 9, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 9, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 9, 2019

⌛ Testing commit a7674aa with merge fe18762...

bors added a commit that referenced this pull request Feb 9, 2019
Do not allow rustup to fail

Currently if rustup fails to download something the build will continue until that something is needed. This makes the job fail early and clearly.
@bors
Copy link
Contributor

bors commented Feb 9, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 9, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 9, 2019

⌛ Testing commit a7674aa with merge 6fc07cc...

bors added a commit that referenced this pull request Feb 9, 2019
Do not allow rustup to fail

Currently if rustup fails to download something the build will continue until that something is needed. This makes the job fail early and clearly.
@bors
Copy link
Contributor

bors commented Feb 9, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 9, 2019

@bors: retry

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 11, 2019

📌 Commit 4a56c47 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 11, 2019

⌛ Testing commit 4a56c47 with merge 563fccc...

bors added a commit that referenced this pull request Feb 11, 2019
Do not allow rustup to fail

Currently if rustup fails to download something the build will continue until that something is needed. This makes the job fail early and clearly.
@bors
Copy link
Contributor

bors commented Feb 11, 2019

💔 Test failed - checks-cirrus

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 12, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 12, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit 4a56c47 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Feb 12, 2019

⌛ Testing commit 4a56c47 with merge ae60e91...

bors added a commit that referenced this pull request Feb 12, 2019
Do not allow rustup to fail

Currently if rustup fails to download something the build will continue until that something is needed. This makes the job fail early and clearly.
@bors
Copy link
Contributor

bors commented Feb 12, 2019

💔 Test failed - checks-cirrus

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 12, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 12, 2019

⌛ Testing commit 4a56c47 with merge d6977c8...

bors added a commit that referenced this pull request Feb 12, 2019
Do not allow rustup to fail

Currently if rustup fails to download something the build will continue until that something is needed. This makes the job fail early and clearly.
@bors
Copy link
Contributor

bors commented Feb 12, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing d6977c8 to master...

@bors bors merged commit 4a56c47 into rust-lang:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants