Skip to content

Add Android items from "sys/system_properties.h" #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

GuillaumeGomez
Copy link
Member

It adds the following items:

  • __system_property_set
  • __system_property_get
  • PROP_VALUE_MAX

 * __system_property_set
 * __system_property_get
 * PROP_VALUE_MAX
@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2021

📌 Commit bea9e05 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Apr 8, 2021

⌛ Testing commit bea9e05 with merge ca641c2...

bors added a commit that referenced this pull request Apr 8, 2021
Add Android items from "sys/system_properties.h"

It adds the following items:
 * __system_property_set
 * __system_property_get
 * PROP_VALUE_MAX
@bors
Copy link
Contributor

bors commented Apr 8, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

Looks like we should include the header here:

headers! { cfg:

@GuillaumeGomez
Copy link
Member Author

@JohnTitor Thanks for the info, added it!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2021

📌 Commit 73200ce has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Apr 8, 2021

⌛ Testing commit 73200ce with merge b80b32b...

@bors
Copy link
Contributor

bors commented Apr 8, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing b80b32b to master...

@bors bors merged commit b80b32b into rust-lang:master Apr 8, 2021
@GuillaumeGomez GuillaumeGomez deleted the add-android-items branch April 8, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants