Skip to content

Add some locale-related functions for openbsd #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2021

Conversation

umanwizard
Copy link
Contributor

These are available since OpenBSD 6.2.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 1, 2021

📌 Commit 39be894 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented May 1, 2021

⌛ Testing commit 39be894 with merge fad1e6f...

@bors
Copy link
Contributor

bors commented May 1, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing fad1e6f to master...

@bors bors merged commit fad1e6f into rust-lang:master May 1, 2021
@semarie
Copy link
Contributor

semarie commented May 2, 2021

@JohnTitor don't hesitate to ping me for OpenBSD related changes as the CI doesn't cover it.

@umanwizard could you complete the PR with adding the new exported functions to libc-test/semver/openbsd.txt ?

@JohnTitor
Copy link
Member

@JohnTitor don't hesitate to ping me for OpenBSD related changes as the CI doesn't cover it.

@umanwizard could you complete the PR with adding the new exported functions to libc-test/semver/openbsd.txt ?

Opened rust-lang/highfive#333 and #2155 to address the above, sorry for the breakage!

bors added a commit that referenced this pull request May 7, 2021
Add some functions added by #2153 to the semver list

r? `@ghost` cc `@semarie`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants