Skip to content

Adding POSIX 'E' error code constants for Windows #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

raphaelcohn
Copy link
Contributor

Believe it or not, Windows actually defines a few POSIX
'E' error codes (eg EINVAL). By adding them to libc, the Windows
bindings for things like read() become useful.

Believe it or not, Windows actually defines a few POSIX
'E' error codes (eg EINVAL). By adding them to libc, the Windows
bindings for things like `read()` become useful.
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 14, 2016

📌 Commit 3784990 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 14, 2016

⌛ Testing commit 3784990 with merge a49950c...

bors added a commit that referenced this pull request Sep 14, 2016
Adding POSIX 'E' error code constants for Windows

Believe it or not, Windows actually defines a few POSIX
'E' error codes (eg EINVAL). By adding them to libc, the Windows
bindings for things like `read()` become useful.
@bors
Copy link
Contributor

bors commented Sep 14, 2016

☀️ Test successful - status-appveyor, travis
Approved by: alexcrichton
Pushing a49950c to master...

@bors bors merged commit 3784990 into rust-lang:master Sep 14, 2016
@raphaelcohn raphaelcohn deleted the windows_posix_errors branch September 15, 2016 07:52
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
No longer support Rust 1.1

Since tempdir is broken on Rust 1.1 I propose to push the minimum supported Rust version to 1.2.
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants