[cherry-pick] Add back aarch64 v8a support #138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since D110065, the 'R' profile support is added to LLVM. It turns the `generic` cpu into the intersection of v8-a and v8-r. However, this makes some backward compatibility problems. The original patch makes the clang driver implicitly pass -march=armv8-a when only the triple is specified. Since it only applies to clang, other tools like llvm-objdump still faces the backward compatibility problem. This patch applies the same idea to MC related tools by enabling '+v8a' feature when nothing is specified (both CPU and FS are empty) for MCSubtargetInfo creation. This patch should fix PR53956. Reviewed by: labrinea Differential Revision: https://reviews.llvm.org/D124319
|
This should probably get an upstream 14.0.x backport? |
|
Yes, this seems reasonable to me to request a backport in LLVM. Backport request: llvm#55182 |
oToToT
changed the title
|
It's now backported to LLVM 14.0.5, should I close this PR? |
|
Yeah, we should merge this from the upstream branch now. Or probably rebase, as this is the final expected LLVM 14.x release. |
vext01
added a commit
to vext01/llvm-project
that referenced
this pull request
Apr 25, 2024
Serialise outlining function attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8689f5e, the
genericCPU for aarch64 is set to the intersection of v8a and v8r.Therefore, some register like el2_ttbr0 is not supported in default setting.
This patch brings them back on default setting to avoid some backward compatibility problems.
Fixes the Rust part of llvm#53956.
(cherry-picked from 4a31af8)