Skip to content

[AVR] Cherry pick llvm#85277 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[AVR] Cherry pick llvm#85277 #171

wants to merge 1 commit into from

Conversation

Patryk27
Copy link

Cherry pick llvm#85277, to fix Rahix/avr-hal#505 🙂

LDDRdPtrQ was marked as `earlyclobber`, which doesn't play well with
GreedyRA (which can generate this instruction through `loadRegFromStackSlot()`).

This seems to be the same case as:

https://github.com/llvm/llvm-project/blob/a99b912c9b74f6ef91786b4dfbc25160c27d3b41/llvm/lib/Target/AVR/AVRInstrInfo.td#L1421

Closes llvm#81911.
@Patryk27 Patryk27 changed the title [AVR] Remove earlyclobber from LDDRdPtrQ (#85277) [AVR] Cherry pick llvm#85277 Mar 15, 2024
@cuviper
Copy link
Member

cuviper commented Mar 15, 2024

Can you propose this for upstream backport to release/18.x?

@Patryk27
Copy link
Author

Sure, sure: llvm#85422.

@Patryk27
Copy link
Author

Oki, got backported!

@nikic
Copy link

nikic commented Mar 19, 2024

Thanks! We'll pick this patch up when merging the LLVM 18.1.2 release which will be tagged later today. I'll go ahead and close this PR...

@nikic nikic closed this Mar 19, 2024
@Patryk27 Patryk27 deleted the fix-avr-hal-505 branch March 20, 2024 09:20
vext01 pushed a commit to vext01/llvm-project that referenced this pull request Jun 5, 2024
Allow loads and stores with align >= the size of the data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants