Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

[MSP430] Fix PR32769: Select8 and Select16 need to have SR in Uses. #75

Merged
merged 1 commit into from
Apr 26, 2017
Merged

[MSP430] Fix PR32769: Select8 and Select16 need to have SR in Uses. #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/Target/MSP430/MSP430InstrInfo.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ def ADJCALLSTACKUP : Pseudo<(outs), (ins i16imm:$amt1, i16imm:$amt2),
}

let usesCustomInserter = 1 in {
let Uses = [SR] in {
def Select8 : Pseudo<(outs GR8:$dst), (ins GR8:$src, GR8:$src2, i8imm:$cc),
"# Select8 PSEUDO",
[(set GR8:$dst,
Expand All @@ -130,6 +131,7 @@ let usesCustomInserter = 1 in {
"# Select16 PSEUDO",
[(set GR16:$dst,
(MSP430selectcc GR16:$src, GR16:$src2, imm:$cc))]>;
}
let Defs = [SR] in {
def Shl8 : Pseudo<(outs GR8:$dst), (ins GR8:$src, GR8:$cnt),
"# Shl8 PSEUDO",
Expand Down
21 changes: 21 additions & 0 deletions test/CodeGen/MSP430/select-use-sr.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
; RUN: llc < %s -march=msp430 | FileCheck %s
; PR32769

target triple = "msp430"

; Test that CMP instruction is not removed by MachineCSE.
;
; CHECK-LABEL: @f
; CHECK: cmp.w r15, r13
; CHECK: cmp.w r15, r13
; CHECK-NEXT: jeq .LBB0_2
define i16 @f(i16, i16, i16, i16) {
entry:
%4 = icmp ult i16 %1, %3
%5 = zext i1 %4 to i16
%6 = icmp ult i16 %0, %2
%7 = zext i1 %6 to i16
%8 = icmp eq i16 %1, %3
%out = select i1 %8, i16 %5, i16 %7
ret i16 %out
}