Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Begin Russian translation #491

Merged
merged 3 commits into from
Aug 29, 2016
Merged

Conversation

mkpankov
Copy link
Contributor

@mkpankov mkpankov commented Aug 25, 2016

This is first spike of Russian translation.

I added a layout for non-translated pages, which is a stub saying "This page is not translated. Please help us translate <GitHub .md file edit link> or read English version ".

The hope is to facilitate translation by making non-translated pages visible. I also got rid of the verbatim copies of English pages in the text of untranslated pages so that there's no duplicated stuff that needs to be updated in sync with original.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Should I just leave off non-translated md's?

This is a good question. I'm not sure what the right answer is.

@mkpankov
Copy link
Contributor Author

@steveklabnik I checked what happens when ru-RU/documentation.md isn't present - it causes 404. So I left the untranslated pages and translated the index.html.

For future work, maybe it makes sense to default to en-US in case there's no file present in the locale? So that it would redirect.

@steveklabnik
Copy link
Member

Yeah, I think that makes sense.

@mkpankov
Copy link
Contributor Author

Updated the PR. I'm gonna put all the details into edited description and make it no longer WIP. Think it's ready.

@mkpankov mkpankov changed the title [WIP] Implement the skeleton of Russian translation Begin Russian translation Aug 29, 2016
@steveklabnik steveklabnik merged commit 0f76eef into rust-lang:master Aug 29, 2016
@steveklabnik
Copy link
Member

Great! Thanks so much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants