Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Fixed Italian è vs é; better .gitignore for macOS #720

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Fixed Italian è vs é; better .gitignore for macOS #720

merged 1 commit into from
Feb 7, 2017

Conversation

agbaroni
Copy link
Contributor

@agbaroni agbaroni commented Feb 7, 2017

The 3rd person of Italian "essere" (= to be) verb is è, not é. It's a serious error.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton alexcrichton merged commit 77b8029 into rust-lang:master Feb 7, 2017
@alexcrichton
Copy link
Member

Thanks!

@agbaroni
Copy link
Contributor Author

agbaroni commented Feb 8, 2017

@alexcrichton I'm reviewing the Italian translation and I saw that ALL accents are wrong. Now, I have a partial patch made with sed covering only è / é characters (I can apply same procedure on other characters); but may be I could accidentally changed some characters in the links to other languages (for example Brazillian). Reviewing word by word would be an hell .... :-(

How can I proceed? I make a pull request and the translators of other languages will review the links?
Thank you.

@alexcrichton
Copy link
Member

cc @gabibbo97, thoughts? (you did the original translation)

@gabibbo97
Copy link
Contributor

@alexcrichton Yup, he is right, using the US International keyboard made me swap the correct accent over each "e" with an accent.
I think we can safely replace every wrong accent with a well structured find & replace operation in any editor

@alexcrichton
Copy link
Member

Ok, thanks @gabibbo97! Want to make a PR @ituxbag?

@gabibbo97
Copy link
Contributor

gabibbo97 commented Feb 8, 2017

@ituxbag Sorry for my mistake, you are 100% correct

Reviewing word by word would be an hell

Yup but if you really need any help I'd gladly mentor you

@agbaroni
Copy link
Contributor Author

agbaroni commented Feb 8, 2017

@alexcrichton @gabibbo97 I made the PR #723.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants