Skip to content

add a general section for the reasoning behind const generics #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2022
Merged

add a general section for the reasoning behind const generics #18

merged 4 commits into from
Feb 9, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Feb 5, 2022

No description provided.

@lcnr lcnr requested a review from nikomatsakis February 5, 2022 13:20
oli-obk
oli-obk reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add examples to make this doc easier to process for someone entirely new to the discussion?

nikomatsakis
nikomatsakis approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start!

@oli-obk oli-obk merged commit c1e2734 into rust-lang:master Feb 9, 2022
@lcnr lcnr deleted the vision branch February 9, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcnr @nikomatsakis @oli-obk