Skip to content

Struct grammar #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Conversation

brauliobz
Copy link
Contributor

Part of #84

Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. 😍 otherwise.

>
> _StructField_ :
> &nbsp;&nbsp; [_OuterAttribute_]<sup>\*</sup>
> &nbsp;&nbsp; [_Visibility_]<sup>?</sup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since visibility contains EMPTY, the ? isn't needed here.

>
> _TupleField_ :
> &nbsp;&nbsp; [_OuterAttribute_]<sup>\*</sup>
> &nbsp;&nbsp; [_Visibility_]<sup>?</sup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise.

@mrhota
Copy link
Contributor

mrhota commented Jan 21, 2018

@brauliobz ping! this PR is just waiting on a couple small adjustments before merge

@Havvy Havvy mentioned this pull request Feb 7, 2018
@matthewjasper matthewjasper merged commit 45e4259 into rust-lang:master Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants