Moar trait object verbiage. #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. While it's "obvious", it should be stated that trait objects actually implement the traits they are for. 2. Added lifetime bounds to the syntactical description and aliasing rules of trait objects. I'm not sure if the aliasing part is correct. 3. Added a big fat warning to the method call expression about trait objects having an inherent impl define a method with the same name as one of the methods the trait object has from the trait. I think that trait objects following different rules than other types should be changed.
steveklabnik
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's "obvious", it should be stated that trait objects actually
implement the traits they are for.
Added lifetime bounds to the syntactical description and aliasing
rules of trait objects. I'm not sure if the aliasing part is correct.
Added a big fat warning to the method call expression about trait
objects having an inherent impl define a method with the same name
as one of the methods the trait object has from the trait. I
think that trait objects following different rules than other types
should be changed.