Skip to content

Revise keywords page #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Revise keywords page #254

merged 1 commit into from
Mar 8, 2018

Conversation

matthewjasper
Copy link
Contributor

@matthewjasper matthewjasper commented Feb 25, 2018

  • List places where keywords are not allowed
  • Move reserved keywords up a section (as they're closer to strict keywords than weak keywords)
  • Don't list box as a strict keyword for now
  • Don't list catch and default as reserved keywords for now, as they're not used in stable Rust.

src/keywords.md Outdated
## Weak keywords

These keywords have special meaning only in certain contexts. For example,
it is possible to declare a variable or method with the name `union`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps include the contexts in which they are reserved?

@matthewjasper matthewjasper force-pushed the keywords branch 2 times, most recently from 8338bbb to b98c59e Compare February 25, 2018 13:07
src/keywords.md Outdated
* [Type parameters]
* Lifetime parameters or [loop labels]
* [Macros] or [attributes]
* [Macro placholders]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: placeholders

* List places where keywords are not allowed
* Move reserved keywords up a section
* Don't list box as a strict keyword for now
* Don't list catch and default as weak keywords for now
* List where weak keywords are used
@matthewjasper
Copy link
Contributor Author

Comments addressed.

@Havvy Havvy merged commit 588eb6d into rust-lang:master Mar 8, 2018
@Havvy
Copy link
Contributor

Havvy commented Mar 8, 2018

💟 Thanks!

@matthewjasper matthewjasper deleted the keywords branch October 18, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants