Warning css #336
Merged
Warning css #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I unfortunately no longer have access to that machine. |
src/trait-bounds.md
Outdated
| ***Warning:*** lifetime bounds are allowed on lifetimes in a `for` binder, but | ||
| have no effect: `for<'a, 'b: 'a>` is no different to `for<'a, 'b>`. | ||
|
|
||
| </div> |
There was a problem hiding this comment.
This stopped being true in 1.26, so can you just remove this warning?
|
As per the meeting, I've increased the contrast on the darker theme links in the warning; I've darkened the warning border in the Rust theme, and I've made the background in the light themes match what @alercah wanted. This is ready for review. |
Havvy
force-pushed
the
warning-css
branch
2 times, most recently
from
534962f to
cb9b457
Compare
|
Rebased. |
QuietMisdreavus
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want warnings to stand out more, so why not give them their own CSS?
I'm not quite sure what this looks like when there's no font that handles the warning sign character, but as long as it's not terrible, it should be fine? It's mostly there for decoration. cc @alercah for having a Linux box that has said lack of font.