Combine related paragraphs and add more details for implementations #401
Conversation
JoshBrudnak
changed the title
|
Fixes: #372 |
src/items/implementations.md
Outdated
| A type can have multiple inherent implementations. | ||
|
|
||
| The implementing type must be defined within the same crate. | ||
| A type can also have multiple inherent implementations. Although the |
There was a problem hiding this comment.
The "Although" used to join here feels very artificial.
There was a problem hiding this comment.
Yes, what if I use "but" instead of "although"
There was a problem hiding this comment.
The "but" implies an exception on the previous statement. An "and" would do well if it cannot read well as two sentences.
There was a problem hiding this comment.
@Havvy Does this sound better: "An implementing type must be defined within the same crate as the original type definition."
|
LGTM. I didn't realize when I did all the changes around here I made the paragraphs so separated like that. My only quibble is that the "Although" joiner really is joining two disparate pieces of information. But that's ultimately a quibble. Since I've touched this page so much, I'd rather the r+ come from another person before merging. |
Havvy
added
the
Language Cleanup
|
@Havvy I separated that second clause into "An implementing type must be defined within the same crate as the original type definition.". |
|
@alercah can you review my changes? Thanks 💯 |
|
@alercah has been busy, and @matthewjasper has given their seal of approval. So gonna merge it. 💟 Thanks! |
No description provided.