Skip to content

Const function #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2018
Merged

Const function #447

merged 3 commits into from
Oct 15, 2018

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Oct 13, 2018

This PR does 7 things:

  1. Capitalize lists.
  2. Define const function with italics.
  3. Call extern and const qualifiers. We may want to look at calling pub a qualifier as well.
  4. Fix enum discriminants to say they take a constant expression.
  5. Explain that const functions have restrictions more tersely.
  6. Fix link to constant expressions on array literal page.
  7. Move attributes on functions back down to the bottom of the page.
  8. Rename FunctionFront to FunctionQualifier in the grammar as well.

The first six are in the first commit. The last two are in their own commit.

Havvy added 2 commits October 13, 2018 03:07
1. Capitalize lists.
2. Define const function with italics.
3. Call extern and const qualifiers. We may want to look at calling
   pub a qualifier as well.
4. Fix enum discriminants to say they take a constant expression.
5. Explain that const functions have restrictions more tersely.
6. Fix link to constant expressions on array literal page.
@matthewjasper matthewjasper merged commit d39911d into rust-lang:master Oct 15, 2018
@matthewjasper
Copy link
Contributor

Thanks!

@Havvy Havvy deleted the const-function branch October 16, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants