fix: fix format string highlighting for todo! and unimplemented!
#10400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 30, 2021
10400: fix: fix format string highlighting for `todo!` and `unimplemented!` r=jonas-schievink a=jonas-schievink Part of #10394 These macros require us to see through the `const_format_args!` invocation the panic macros generate, for that we have to add it to our supported built-in macros. I've also made the macros in the test `#[macro_export]` (turns out they didn't all resolve correctly before this), which changes the output slightly. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
|
Canceled. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10394
These macros require us to see through the
const_format_args!invocation the panic macros generate, for that we have to add it to our supported built-in macros.I've also made the macros in the test
#[macro_export](turns out they didn't all resolve correctly before this), which changes the output slightly.bors r+