refactorings and FIXME fixes in text edit #11573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isokaeder
force-pushed
the
small-refactor-text-edit
branch
2 times, most recently
from
2b51acb to
ff59147
Compare
lnicola
reviewed
Feb 27, 2022
| text_edit.apply(&mut text); | ||
|
|
||
| assert_eq!(text, "_1111_2222_3333_4444_5555_6666") | ||
| } |
There was a problem hiding this comment.
Nit: please add the trailing newline.
|
bors r+ changelog internal (first contribution) reuse buffer in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly me learning some rust, and only anecdotally about addressing some
fixmes. Feel free to nope :)There is a follow up PR in the pipeline which tackles the other two
fixmes but it's a bit more invasive. So I wanted to get this out of the way