Skip to content

Fix a typo in the inlayHints.renderColons option description #12212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2022

Conversation

Elliot-Roberts
Copy link

The description said the same thing twice: "trailing colons for parameter hints, and trailing colons for parameter hints".
I'm assuming one of those is supposed to be about the leading colon for type hints.

Also, I wasn't sure how to regenerate the generated file(s?) so I just manually updated them. Hopefully that isn't a problem. If how to do that is in the documentation somewhere I'd love to know.

@Elliot-Roberts
Copy link
Author

Elliot-Roberts commented May 11, 2022

Also sorry if tiny typo PRs like this are unwanted. I scanned the contributing info files but wasn't sure. If I didn't just miss it somewhere, it would be cool to clarify whether these are welcome.

@lnicola
Copy link
Member

lnicola commented May 11, 2022

Thanks!

I wasn't sure how to regenerate the generated file(s?)

cargo test does that.

@bors r+

it would be cool to clarify whether these are welcome

Every (reasonable) PR is welcome, even if it's a minor typo like a comma :-).

@bors
Copy link
Contributor

bors commented May 11, 2022

📌 Commit 2298a76 has been approved by lnicola

@bors
Copy link
Contributor

bors commented May 11, 2022

⌛ Testing commit 2298a76 with merge be770a7...

@bors
Copy link
Contributor

bors commented May 11, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing be770a7 to master...

@bors bors merged commit be770a7 into rust-lang:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants