internal: Try to improve the rustfmt.overrideCommand docs
#14183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @lowr |
lowr
reviewed
Feb 21, 2023
crates/rust-analyzer/src/config.rs
Outdated
Comment on lines
459
to
460
| /// formatting. This should be the equivalent of `rustfmt` here, and | ||
| /// not that of `cargo fmt`. |
There was a problem hiding this comment.
It might be worth making explicit that the command should read code to format from stdin and write formatted code back to stdout.
lnicola
force-pushed
the
rustfmt-command-docs
branch
from
b9556d0 to
563bd9c
Compare
lowr
approved these changes
Feb 21, 2023
|
@bors r=lowr |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
rustfmt.overrideCommand docsrustfmt.overrideCommand docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14078