Skip to content

internal: Set expectation for no-semi expression statements to unit #14251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2023
Merged

internal: Set expectation for no-semi expression statements to unit #14251

merged 5 commits into from
Mar 4, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 4, 2023

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2023
@Veykril
Copy link
Member Author

Veykril commented Mar 4, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2023

📌 Commit 24ba1be has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 4, 2023

⌛ Testing commit 24ba1be with merge c922133...

bors added a commit that referenced this pull request Mar 4, 2023
@bors
Auto merge of #14251 - Veykril:ty-expr-stmt, r=Veykril
c922133 
internal: Set expectation for no-semi expression statements to unit
@Veykril
Copy link
Member Author

Veykril commented Mar 4, 2023

Tempted to disable the typescript tests as they keep spuriously failing

@bors
Copy link
Contributor

bors commented Mar 4, 2023

💔 Test failed - checks-actions

@Veykril
Copy link
Member Author

Veykril commented Mar 4, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2023

📌 Commit b85e2af has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 4, 2023

⌛ Testing commit b85e2af with merge 94dc7a3...

@bors
Copy link
Contributor

bors commented Mar 4, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 94dc7a3 to master...

@bors bors merged commit 94dc7a3 into rust-lang:master Mar 4, 2023
@mohon8156 mohon8156 linked an issue Mar 13, 2023 that may be closed by this pull request
Data analytics and ads work service #14341
Closed
@Veykril Veykril deleted the ty-expr-stmt branch March 25, 2023 13:23
@lowr lowr mentioned this pull request Apr 6, 2023
Merged
bors added a commit that referenced this pull request Apr 6, 2023
@bors
Auto merge of #14520 - lowr:fix/unify-variable-fallout, r=Veykril
ca0f6bb 
fix: unify types in `infer_expr_coerce_never()`

Fixes #14506

#14506 turned out to be a regression in type inference. `infer_expr_coerce_never()` added in #14251 allows never-to-any coercion but should also perform ordinary type unification in other cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data analytics and ads work service
3 participants
@Veykril @bors @rustbot