Turn BlockId into a #[salsa::tracked]
#19995
Merged
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-zpyyzqqpywno
branch
from
0e1ef92 to
8643a85
Compare
| type Database = dyn DefDatabase; | ||
| type ID = BlockId; | ||
| fn intern(self, db: &Self::Database) -> Self::ID { | ||
| unsafe { std::mem::transmute::<BlockIdLt<'_>, BlockId>(BlockIdLt::new(db, self)) } |
There was a problem hiding this comment.
I... don't like this thing.
There was a problem hiding this comment.
Well, that's how all the interned work right now. This just does the same for tracked structs since they dont have support for it. Ideally we'd have the lifetime everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need interned equality based identity here